ed_installation_parms produces spurious name duplication error

[Eric Swenson]

When you invoke ed_installation_parms >sc1>installation_parms in a new process, you get the error:

ed_installation_parms: Name duplication. rate_structure_0 >sc1>installation_parms.

This error occurs because the error code checking logic is inadequate.

After parsing arguments, it calls:

call hcs_$make_seg (dn, en, "", RW_ACCESS_BIN, rsp1, ec);

In the normal case, where the parameter was >sc1>installation_parms, and where that segment exists, ec will be error_table_$namedup ("Name duplication."). The code handles two cases: ec = 0 and ec = error_table_$segknown. ec is neither of these, so we fall through to:

        call com_err_ (ec, me, "rate_structure_^d ^a.", i, dnvar || rtrim (en));
        go to exit;

So that’s why we fail. This is a stupid way of doing it. Of course, when we exit with this error, we still have >sc1>installation_parms initiated (not cleaned up), so the second invocation results in ec being error_table_$segknown and things work better.