configure_test_cpu returns incorrect error code.

[canthony]

'configure_test_cpu' does many checks and returns a wide variety of error codes, two of which are shown here:

      if ^found then do;                                /* didn't find mask */
           rcode = rcerr_isolts_no_mask;
           return;
      end;

and

     call set_procs_required (cpu_mask, tcode);
      if tcode ^= 0 then do;
           rcode = rcerr_sprq_failed;
           return;
      end;

Looking in rcerr.incl.pl1, we see:

 rcerr_sprq_failed init (17)                            /* could not set CPU required */

and

rcerr_isolts_no_mask init (17)                         /* No mask set for test cpu */

Every other error code used in 'configure_test_cpu' is of the form 'rcerr_isolts_xxxxx'.
The following line needs to be added to rcerr.incl.pl1:

rcerr_isolts_sprq_failed init (18)                     /* could not set CPU required */

The line in configure_test_cpu.pl1:

          rcode = rcerr_sprq_failed;

needs to be changed to:

           rcode = rcerr_isolts_sprq_failed;

[Eric Swenson]

The 'rcode = rcerr_sprq_failed;' line occurs twice in configure_test_cpu.pl1. -- Charles

[Eric Swenson]

Ticket moved here from ​https://sourceforge.net/p/dps8m/tickets/103/

[Eric Swenson]

The manifestation of this bug is that ISOLTS reports an incorrect error message:

isolts: the following errors were detected while attempting reconfiguration:

isolts: scu b has no interrupt mask register assigned to cpu b

***isolts executive version 116011 off 211223 at 13.392

***enter "polts", "molts", "colts", "isolts", "quit", or "msg"
???

when the user doesn't have permissions to set the required processor. This permission is based on having rw access on the ACS >sc1>admin_acs>set_proc_required.acs.

[Eric Swenson]

​https://s3.amazonaws.com/eswenson-multics/public/mcrs/MCR10107.pdf

[Eric Swenson]

Installed: MCR10107, MR12.8-1018