Opened 8 years ago

Closed 17 months ago

#140 closed defect (fixed)

operator command detach produces incorrectly formatted error messages

Reported by: charles.unix.pro@… Owned by: Eric Swenson
Priority: minor Milestone: MR12.9
Component: Tools Version: MR12.8
Keywords: Cc:

Description

The command "detach tape8" was inadvertently enter on the console, producing the error message:

M-> detach disk8

\000\234\400#\320\000\000\000\000\000\005\017\000\000\000\000\000\000\000\000\00\651\000\000\000\000\000\000\000\004\000\000\000\001\000\000\000\006\000\000\000\000: error: Usage: \000\234\400#\320\000\000\000\000\000\005\017\000\000\000\00\651\000\000\000\000\000\000\000\004\000\000\000\001\000\000\000\006\000\000\000\000 (Person.Project|CHANNEL|mpx MPX) {TIME MESSAGE}
The "Person Project" format is obsolete.
Ready


ldd>tools>s>bound_as_misc_.s.archive::operator_process_cmds_.pl1

detach: entry options (variable);

/**** This entry implements the operator "detach" command.  It forceably
      logs out a user and makes the tty unresponsive */

          arg_list_ptr = cu_$arg_list_ptr ();
          call process_bump_args (arg_list_ptr, ""b);

          action = "detach";
          action_log = "detached";
          comname = "operator_process_cmds_: detach";

          call process_bump_args (arg_list_ptr, ""b);

seems incorrect; process_bump_args should not be called twice as far as I can tell. The random string is produced on the first call, before comname has been initialized.

I believe the first call should be deleted. Examination of the other entry points (terminate, bump, unbump and disconnect) show that pattern.

Change History (2)

comment:1 by Eric Swenson, 18 months ago

Component: Hardcore → Tools
Milestone: → MR12.9
Status: new → accepted
Version: → MR12.8

​https://s3.amazonaws.com/eswenson-multics/public/mcrs/MCR10145-v1.0.pdf

comment:2 by Eric Swenson, 17 months ago

Resolution: → fixed
Status: accepted → closed

Fixed with MR12.9-1011.

Note: See TracTickets for help on using tickets.