scavenger fails to detect VTOC directory head name list mismatch with actual entry name.

[canthony]

VTOC entries that are directories have a linked list of the names and UIDs of the segments in the directory. When a segment is added to a directory, the UID of the segment and the name of the segment from the segment's VTOC entry is added to the list.

In the entry list of ">user_dir_dir>SysAdmin>Repair", there is an entry with the UID of 512721003207 and the name mfrotz_segs.

display_branch >user_dir_dir>SysAdmin>Repair>mfrotz_segs

Branch for mfrotz_segs in >user_dir_dir>SysAdmin>Repair at 246|10022

UID 512721003207, is vtocx 4552 on root2 (of log vol. root)
mfrotz_segs is a directory.
Ring brackets (0 0 0)
Entry modified 03/16/19 1412.2 pst Sat
Never dumped.
Access Class: system_low

"vtoc_pathname" also considers this to be the correct name.

vtoc_pathname root2 4552
Pvtx 2 vtocx 4552 = >user_dir_dir>SysAdmin>Repair>mfrotz_segs

However, "display_vtoce" agrees that the UID is correct, but shows a different name:

display_vtoce root2 4552

VTOCE "mfrotz" (Directory), vtocx 4552 on pvtx 2 (root2)

UID: 512721003207, msl: 205, csl: 1, records: 1

Quota used (S D) ( 5 1)

Created 2018-06-22 12:53:36.535552 pst
Never dumped
Used 2019-03-02 20:06:56.706560 pst
Modified 2018-06-22 13:37:16.861440 pst

ON:
OFF: deciduous per_process nqsw master_dir nid ncd dnzp damaged

synchronized fm_damaged fm_checksum_valid

Access Class: system_low

Note that a directory >user_dir_dir>SysAdmin>Repair>mfrotz also exists, but has a different UID.

ls >user_dir_dir>SysAdmin>Repair>mfrotz* -a

Directories = 2.

sma mfrotz
sma mfrotz_segs

display_branch >user_dir_dir>SysAdmin>Repair>mfrotz

Branch for mfrotz in >user_dir_dir>SysAdmin>Repair at 246|10110

UID 512721003344, is vtocx 435 on rpv (of log vol. root)
mfrotz is a directory.
Ring brackets (0 0 0)
Entry modified 03/16/19 1412.2 pst Sat
Never dumped.
Access Class: system_low

[canthony]

The disk being examined has many mis-matched names; looking at them makes me think that they are mostly files that I renamed; so possibly there is a bug in rename.

[canthony]

Running salvager with "-check_vtoce" fixes this.