Opened 3 years ago

Closed 5 weeks ago

#321 closed enhancement (fixed)

accounts_overseer_.pl1 (for SA1) should have a larger command buffer and should not execute an incomplete command

Reported by: David Rosenberg Owned by: Eric Swenson
Priority: minor Milestone: MR12.9
Component: Standard Library Version: MR12.5
Keywords: accounts_overseer_, SA1, command buffer Cc:

Description

I stored an exec_com in >user_dir_dir>SysAdmin>admin and tried executing it as SA1.

One of the commands in the exec_com was an enter_abs_request command which had a lot of control arguments and (using the -arguments control argument) passed a lot of arguments to the absentee job. After expansion the command was 284 characters long. The error message

accounts_overseer_: Record is too long.

was produced, but the enter_abs_request command was executed anyway - apparently using only the first 211 characters and ignoring characters after that.

I have two suggestions:

  1. accounts_overseer_ should not execute part of a command that was truncated. If the whole command can't be executed, don't execute just part of it.
  2. Expand accounts_overseer_'s command buffer to accommodate longer commands. I don't know what size to recommend. I would think at least 1,000 characters, but larger than that might be more appropriate.

Change History (3)

comment:1 by Eric Swenson, 6 weeks ago

Milestone: → MR12.9
Status: new → assigned
Version: → MR12.5

comment:3 by Eric Swenson, 5 weeks ago

Resolution: → fixed
Status: assigned → closed

Fixed in MR12.9-1050.

Note: See TracTickets for help on using tickets.