Opened 3 years ago

Closed 10 days ago

Last modified 10 days ago

#325 closed defect (fixed)

_ssu_check_sci.incl.pl1 error messages should identify nature of failed check more clearly

Reported by: Gary Dixon Owned by: Gary Dixon
Priority: minor Milestone: MR12.9
Component: Standard Library Version: MR12.8
Keywords: Cc:

Description

Several bound_ssu_ source programs call the ssu_check_sci procedure in _ssu_check_sci.incl.pl1 to validate the sci_ptr argument (pointer to ssu control information) passed as the first argument in many ssu_ subroutine calls. It makes three checks on the sci_ptr value, and calls sub_err_ if any of those checks fail. Unfortunately, those sub_err_ calls don't contain enough information to properly diagnose the nature of the failure.

I propose the following changes to generate clearer messages.

A43                      call sub_err_ (error_table_$bad_ptr, SSU_, ACTION_CANT_RESTART, null (), (0), "^24.3b", unspec (p_sci_ptr)
\c);
Changed by B to:
B46                      call sub_err_ (error_table_$bad_ptr, SSU_, ACTION_CANT_RESTART, null (), (0),
B47                                     " sci_ptr has invalid ITS modifier: ^24.3b", unspec (p_sci_ptr));


A49                      call sub_err_ (error_table_$null_info_ptr, SSU_, ACTION_CANT_RESTART, null (), (0), "sci_ptr");
Changed by B to:
B53                      call sub_err_ (error_table_$null_info_ptr, SSU_, ACTION_CANT_RESTART, null (), (0), " sci_ptr");


A57                 call sub_err_ (error_table_$unimplemented_version, SSU_, ACTION_CANT_RESTART, null (), (0), "^24.3b",
A58                      unspec (p_sci_ptr -> sci.version));
Changed by B to:
B61                 call sub_err_ (error_table_$unimplemented_version, SSU_, ACTION_CANT_RESTART, null (), (0),
B62                                " sci_ptr -> sci.version: ^24.3b", unspec (p_sci_ptr -> sci.version));

Comparison finished: 3 differences, 8 lines.

Change History (4)

comment:1 by Gary Dixon, 13 months ago

Owner: changed from Eric Swenson to Gary Dixon
Status: newaccepted

comment:3 by Eric Swenson, 10 days ago

Resolution: fixed
Status: acceptedclosed

Installed as MR12.9-1037.

comment:4 by Eric Swenson, 10 days ago

Milestone: MR12.9
Note: See TracTickets for help on using tickets.