Opened 2 days ago

Last modified 6 hours ago

#443 new defect

network_local_data_.alm contains obsolete fields apparently no longer used

Reported by: Jim Lippard Owned by: Eric Swenson
Priority: minor Milestone: No Milestore
Component: Networking Version: MR12.9
Keywords: networking, network_local_data_.alm Cc:

Description

access_data: set to >site>net>acs, returned by network_local_info_$get_access_control_directory, which is apparently called by nothing.

mailer_data: set to >site>net>mailer and apparently not used anywhere.

port_access: defines access policies (that are actually controlled by ACS segments), but apparently not used anywhere.

Change History (1)

comment:1 by Jim Lippard, 6 hours ago

Further clarification on all three:

port_access — the macro body in network_local_macros.incl.alm is empty, so the port_access lines in network_local_data_.alm assemble to nothing. It doesn't and can't do anything. These lines can come straight out of the template with no code change, since the macro defines no symbol for anything to reference.

mailer_data — the mail_dir macro (network_local_macros.incl.alm:187) does define network_local_data_$mailer_queue_directory, read in network_local_info_.pl1 at the declaration (139), the get_mailer_queue_directory accessor (241/247), and check_pathname (555). get_mailer_queue_directory has no callers anywhere in the tree, so the value is never used for anything. Removing it requires removing the macro plus all four references in network_local_info_.pl1 — deleting only the site data line leaves an undefined symbol at 555.

access_dir — same shape: defines network_local_data_$access_control_directory, read in network_local_info_.pl1 at 123, 171 (via get_access_control_directory, also with no callers), and check_pathname (552). No access decisions use it. Those are made with ip_site_constants_$access_control_directory, set in ip_site_constants_.alm:17 to >site>network>data, and read by check_port_access in tcp_open_ (506/509) and udp_port_mgr_ (399/402), plus copied into ip_data by ip_attach_util_ (444) for ip_protocol_server_ and ip_network_driver_.

This one is actively misleading rather than merely unused: an admin reading access_dir would create the ACS directory it names, put tcp.well_known_ports.acs there, and get no port access control at all, because the lookup goes to >site>network>data. Same removal hazard as mailer_data — line 552 references it unconditionally.

And if you did want to move the ACS directory, it's a reassembly of ip_site_constants_.alm, not network_local_data_.alm. The runtime routes were both removed: the ip_hpriv_$set_access_control_directory gate and ip_call's sacd request (Installations.log:431/434).

Note: See TracTickets for help on using tickets.